feat(wio-e5): promote Seeed Wio-E5 to actively supported - #11648
Draft
ndoo wants to merge 1 commit into
Draft
Conversation
Add the custom_meshtastic_* metadata block to [env:wio-e5], mirroring [env:rak4631] and [env:rak3172], so bin/platformio-custom.py emits a manifest with activelySupported=true, supportLevel=1, hwModel=73 and hwModelSlug=WIO_E5. The flasher board list and api.meshtastic.org/resource/deviceHardware are generated from these per-board manifests, so the board now appears as a selectable device. displayName is "Seeed Wio-E5", covering both boards the variant builds for. No custom_meshtastic_images: web-flasher has no wio-e5.svg. board_level stays pr (the smallest matrix subset, also built in every larger matrix), matching [env:rak4631] and [env:rak3172]. Rewrite the variant.h header comment: drop the "work in progress / do not expect a working device" disclaimer, which contradicts an actively supported declaration, and state that the one variant covers both the Wio-E5 Development Kit and the Wio-E5 mini, which share the LoRa-E5 module pin map and the PB5 status LED. No protobuf change: WIO_E5 = 73 and the HW_VENDOR mapping for _VARIANT_WIOE5_ already exist. Assisted-by: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Andrew Yong <me@ndoo.sg>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
⚡ Try this PR in the Web FlasherNote Building this pull request… the flash button, badges and supported-board |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Promotes the
wio-e5STM32WL variant to an actively supported Meshtastic device, mirroring #11647 forrak3172.Adds the
custom_meshtastic_*metadata block to[env:wio-e5]invariants/stm32/wio-e5/platformio.ini, alongside the existing[env:rak4631]and[env:rak3172]blocks.bin/platformio-custom.pyreads these keys and emits a per-board build manifest withactivelySupported: true,supportLevel: 1,hwModel: 73,hwModelSlug: "WIO_E5",architecture: "stm32",displayName: "Seeed Wio-E5",tags: ["Seeed"]. The web flasher board list andapi.meshtastic.org/resource/deviceHardwareare generated from those manifests, so the board becomes a selectable device.displayNameisSeeed Wio-E5because this single variant builds firmware for both Seeed boards that carry the LoRa-E5 (STM32WLE5JC) module: the Wio-E5 Development Kit and the Wio-E5 mini. They share the module pin map and the PB5 status LED.custom_meshtastic_imagesis omitted becausemeshtastic/web-flasherhas nowio-e5.svg; the flasher and the CI board-diff comment degrade to no image.board_levelstayspr(the smallest CI matrix subset, also built in every larger matrix), matching[env:rak4631]and[env:rak3172].variants/stm32/wio-e5/variant.h: the header comment is rewritten to drop the "work in progress / do not expect a working Meshtastic device" disclaimer, which contradicts an actively-supported declaration, and to record that the one variant covers both boards. The current Seeed wiki URLs replace the dead store links. No code invariant.hchanges (LED_POWER PB5, theWIO_E5define, and the guards are untouched).No protobuf change:
WIO_E5 = 73and theHW_VENDORmapping for_VARIANT_WIOE5_already exist in the tree.Verification
pio run -e wio-e5succeeds. Flash 93.0% (230384 / 247808 bytes), RAM 41.5% (27172 / 65536 bytes). The generated.pio/build/wio-e5/firmware-wio-e5-*.mt.jsoncontains the expectedactivelySupported,supportLevel,hwModel,hwModelSlug,architecture,displayName, andtagsvalues../bin/generate_ci_matrix.py stm32 --level prstill listswio-e5.trunk fmtclean on both files.🤝 Attestations